pipeline siivous ja testikattavuuden nosto (#9)

Co-authored-by: moilanik <niko.moilanen@tietoevry.com>
Reviewed-on: #9

tests/dispatch-workflow.bats

@@ -2,8 +2,6 @@
 
 setup() {
   source tests/helpers/mock-api.sh
-  export GITEA_API_URL="http://localhost:18080"
-  export GITEA_TOKEN="test-token-abc123"
   export DISPATCH_POLL_INTERVAL="0.1"
 }
 
@@ -21,7 +19,7 @@ teardown() {
     {"code":200,"body":{"id":1,"status":"completed","conclusion":"success"}}
   ]'
   mock_start
-  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "test.yml" "main" '{"version":"1.2.3"}'
+  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "test.yml" "main" '{"version":"1.2.3"}' "http://localhost:18080" "test-token-abc123"
   [ "$status" -eq 0 ]
 }
 
@@ -33,7 +31,7 @@ teardown() {
     {"code":200,"body":{"id":1,"status":"completed","conclusion":"failure"}}
   ]'
   mock_start
-  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "test.yml" "main" '{"version":"1.2.3"}'
+  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "test.yml" "main" '{"version":"1.2.3"}' "http://localhost:18080" "test-token-abc123"
   [ "$status" -eq 1 ]
 }
 
@@ -45,7 +43,7 @@ teardown() {
     {"code":200,"body":{"id":1,"status":"completed","conclusion":"cancelled"}}
   ]'
   mock_start
-  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "test.yml" "main" '{"version":"1.2.3"}'
+  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "test.yml" "main" '{"version":"1.2.3"}' "http://localhost:18080" "test-token-abc123"
   [ "$status" -eq 1 ]
 }
 
@@ -63,7 +61,7 @@ teardown() {
     {"code":200,"body":{"id":1,"status":"running"}}
   ]'
   mock_start
-  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "test.yml" "main" '{"version":"1.2.3"}' "0.001"
+  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "test.yml" "main" '{"version":"1.2.3"}' "http://localhost:18080" "test-token-abc123" "0.001"
   [ "$status" -eq 124 ]
 }
 
@@ -72,7 +70,7 @@ teardown() {
     {"code":500}
   ]'
   mock_start
-  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "test.yml" "main" '{"version":"1.2.3"}'
+  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "test.yml" "main" '{"version":"1.2.3"}' "http://localhost:18080" "test-token-abc123"
   [ "$status" -eq 1 ]
 }
 
@@ -83,7 +81,7 @@ teardown() {
     {"code":200,"body":{"id":1,"status":"completed","conclusion":"success"}}
   ]'
   mock_start
-  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "test.yml" "main" '{"version":"1.2.3"}'
+  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "test.yml" "main" '{"version":"1.2.3"}' "http://localhost:18080" "test-token-abc123"
   [ "$status" -eq 0 ]
   path=$(mock_get_first_request_path)
   [[ "$path" == *"/api/v1/repos/test-owner/test-repo/actions/workflows/test.yml/dispatches"* ]]
@@ -95,36 +93,45 @@ teardown() {
   [[ "$body" == *'"version":"1.2.3"'* ]]
 }
 
-@test "missing GITEA_API_URL → exit 1 with error message" {
-  unset GITEA_API_URL
-  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "test.yml" "main" '{"version":"1.2.3"}'
+@test "missing gitea_api_url argument → exit 1 with error message" {
+  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "test.yml" "main" '{"version":"1.2.3"}' "" "test-token-abc123"
   [ "$status" -eq 1 ]
-  [[ "$output" == *"ERROR"* || "$output" == *"GITEA_API_URL"* ]]
+  [[ "$output" == *"ERROR"* || "$output" == *"gitea_api_url"* ]]
 }
 
-@test "missing GITEA_TOKEN → exit 1 with error message" {
-  unset GITEA_TOKEN
-  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "test.yml" "main" '{"version":"1.2.3"}'
+@test "missing gitea_token argument → exit 1 with error message" {
+  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "test.yml" "main" '{"version":"1.2.3"}' "http://localhost:18080" ""
   [ "$status" -eq 1 ]
-  [[ "$output" == *"ERROR"* || "$output" == *"GITEA_TOKEN"* ]]
+  [[ "$output" == *"ERROR"* || "$output" == *"gitea_token"* ]]
 }
 
 @test "missing target_repo argument → exit 1" {
-  run bash scripts/dispatch-workflow.sh "" "test.yml" "main" '{}'
+  run bash scripts/dispatch-workflow.sh "" "test.yml" "main" '{}' "http://localhost:18080" "test-token-abc123"
   [ "$status" -eq 1 ]
 }
 
 @test "missing workflow_file argument → exit 1" {
-  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "" "main" '{}'
+  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "" "main" '{}' "http://localhost:18080" "test-token-abc123"
   [ "$status" -eq 1 ]
 }
 
 @test "missing ref argument → exit 1" {
-  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "test.yml" "" '{}'
+  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "test.yml" "" '{}' "http://localhost:18080" "test-token-abc123"
   [ "$status" -eq 1 ]
 }
 
+@test "dispatch: no workflow run found after dispatch → exit 1" {
+  mock_set_sequence '[
+    {"code":201},
+    {"code":200,"body":{"workflow_runs":[]}}
+  ]'
+  mock_start
+  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "test.yml" "main" '{}' "http://localhost:18080" "test-token-abc123"
+  [ "$status" -eq 1 ]
+  [[ "$output" == *"ERROR"* ]]
+}
+
 @test "missing inputs_json argument → exit 1" {
-  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "test.yml" "main" ""
+  run bash scripts/dispatch-workflow.sh "test-owner/test-repo" "test.yml" "main" "" "http://localhost:18080" "test-token-abc123"
   [ "$status" -eq 1 ]
 }