From a40a7703f047ee10ec02dd79e8ce7a7209dd6d6f Mon Sep 17 00:00:00 2001
From: moilanik <niko.moilanen@tietoevry.com>
Date: Fri, 19 Jun 2026 07:55:30 +0300
Subject: [PATCH] check version testit

---
 git-pages/README.md                           |   2 +-
 scripts/check-version.sh                      |  15 +-
 tests/check-version.bats                      | 170 ++++++++++++++++++
 tests/fixtures/check-version/Chart.yaml       |   6 +
 tests/fixtures/check-version/VERSION          |   1 +
 tests/fixtures/check-version/package.json     |   1 +
 tests/fixtures/check-version/pom.xml          |   1 +
 .../fixtures/check-version/subdir/Chart.yaml  |   6 +
 8 files changed, 194 insertions(+), 8 deletions(-)
 create mode 100644 tests/check-version.bats
 create mode 100644 tests/fixtures/check-version/Chart.yaml
 create mode 100644 tests/fixtures/check-version/VERSION
 create mode 100644 tests/fixtures/check-version/package.json
 create mode 100644 tests/fixtures/check-version/pom.xml
 create mode 100644 tests/fixtures/check-version/subdir/Chart.yaml

diff --git a/git-pages/README.md b/git-pages/README.md
index 321b7ed..9b47223 100644
--- a/git-pages/README.md
+++ b/git-pages/README.md
@@ -68,7 +68,7 @@ open "https://gitea.app.keskikuja.site/${REPO_OWNER}/${REPO_NAME}/settings/actio
 
 > 💡 **Monelle repoille:** Toista vaiheet 3–4, tai katso [automatisointi](docs/secrets.md#automatisointi-useamman-repon-salaisuuden-lis%C3%A4%C3%A4miseen).
 
---- 
+---
 
 ## Käyttöönotto
 
diff --git a/scripts/check-version.sh b/scripts/check-version.sh
index ba05d8d..6adcf77 100755
--- a/scripts/check-version.sh
+++ b/scripts/check-version.sh
@@ -4,12 +4,13 @@ set -e
 RAW_VERSION=""
 
 if [ -n "${VERSION_FILE}" ] && [ -f "${VERSION_FILE}" ]; then
-  if echo "${VERSION_FILE}" | grep -q -E '\.json$'; then
-    RAW_VERSION=$(jq -r '.version' "${VERSION_FILE}")
-  elif echo "${VERSION_FILE}" | grep -q -E '\.(ya?ml)$'; then
-    RAW_VERSION=$(grep -oP '^version:\s*\K\S+' "${VERSION_FILE}")
-  else
-    RAW_VERSION=$(cat "${VERSION_FILE}" | tr -d '[:space:]')
+  RAW_VERSION=$(sed -n 's/^version:[[:space:]]*\([^[:space:]]*\).*/\1/p' "${VERSION_FILE}")
+  if [ -z "${RAW_VERSION}" ]; then
+    if echo "${VERSION_FILE}" | grep -q -E '\.json$'; then
+      RAW_VERSION=$(jq -r '.version' "${VERSION_FILE}")
+    else
+      RAW_VERSION=$(cat "${VERSION_FILE}" | tr -d '[:space:]')
+    fi
   fi
 fi
 
@@ -21,7 +22,7 @@ if [ -z "${RAW_VERSION}" ]; then
   elif [ -f pom.xml ]; then
     RAW_VERSION=$(grep -oP '<version>\K[^<]+' pom.xml | head -1)
   elif [ -f Chart.yaml ]; then
-    RAW_VERSION=$(grep -oP '^version:\s*\K\S+' Chart.yaml)
+    RAW_VERSION=$(sed -n 's/^version:[[:space:]]*\([^[:space:]]*\).*/\1/p' Chart.yaml)
   else
     echo "ERROR: No version source found (VERSION_FILE, VERSION, package.json, pom.xml, Chart.yaml)" >&2
     exit 1
diff --git a/tests/check-version.bats b/tests/check-version.bats
new file mode 100644
index 0000000..6618e94
--- /dev/null
+++ b/tests/check-version.bats
@@ -0,0 +1,170 @@
+#!/usr/bin/env bats
+
+source "$BATS_TEST_DIRNAME/helpers/mock-api.sh"
+
+setup() {
+  export GITEA_TOKEN=test-token
+  export GIT_TAG_PREFIX=""
+  export SERVER_URL="http://localhost:18080"
+  export REPO="niko/test"
+  export SHA="abc123"
+  rm -rf /tmp/build-ctx
+}
+
+teardown() {
+  mock_stop 2>/dev/null || true
+  rm -rf /tmp/build-ctx
+}
+
+@test "VERSION_FILE=Chart.yaml extracts version from YAML" {
+  mock_set_sequence '[{"code": 200, "body": []}]'
+  mock_start
+
+  export VERSION_FILE="$BATS_TEST_DIRNAME/fixtures/check-version/Chart.yaml"
+  run bash scripts/check-version.sh
+
+  [ "$status" -eq 0 ]
+  source /tmp/build-ctx/build.env
+  [ "$ARTIFACT_EXISTS" = "false" ]
+  [ "$NEXT_VERSION" = "0.3.0" ]
+}
+
+@test "VERSION_FILE=VERSION extracts version from plain text" {
+  mock_set_sequence '[{"code": 200, "body": []}]'
+  mock_start
+
+  export VERSION_FILE="$BATS_TEST_DIRNAME/fixtures/check-version/VERSION"
+  run bash scripts/check-version.sh
+
+  [ "$status" -eq 0 ]
+  source /tmp/build-ctx/build.env
+  [ "$ARTIFACT_EXISTS" = "false" ]
+  [ "$NEXT_VERSION" = "0.3.0" ]
+}
+
+@test "VERSION_FILE=package.json extracts version from JSON" {
+  mock_set_sequence '[{"code": 200, "body": []}]'
+  mock_start
+
+  export VERSION_FILE="$BATS_TEST_DIRNAME/fixtures/check-version/package.json"
+  run bash scripts/check-version.sh
+
+  [ "$status" -eq 0 ]
+  source /tmp/build-ctx/build.env
+  [ "$ARTIFACT_EXISTS" = "false" ]
+  [ "$NEXT_VERSION" = "0.3.0" ]
+}
+
+@test "VERSION_FILE=subdir/Chart.yaml extracts version from monorepo" {
+  mock_set_sequence '[{"code": 200, "body": []}]'
+  mock_start
+
+  export VERSION_FILE="$BATS_TEST_DIRNAME/fixtures/check-version/subdir/Chart.yaml"
+  run bash scripts/check-version.sh
+
+  [ "$status" -eq 0 ]
+  source /tmp/build-ctx/build.env
+  [ "$ARTIFACT_EXISTS" = "false" ]
+  [ "$NEXT_VERSION" = "0.4.0" ]
+}
+
+@test "no VERSION_FILE, root VERSION found" {
+  mock_set_sequence '[{"code": 200, "body": []}]'
+  mock_start
+
+  WORKDIR=$(mktemp -d)
+  cp "$BATS_TEST_DIRNAME/fixtures/check-version/VERSION" "$WORKDIR/VERSION"
+
+  pushd "$WORKDIR" >/dev/null
+  run bash "$OLDPWD/scripts/check-version.sh"
+  popd >/dev/null
+
+  rm -rf "$WORKDIR"
+  [ "$status" -eq 0 ]
+  source /tmp/build-ctx/build.env
+  [ "$NEXT_VERSION" = "0.3.0" ]
+}
+
+@test "no VERSION_FILE, root Chart.yaml found" {
+  mock_set_sequence '[{"code": 200, "body": []}]'
+  mock_start
+
+  WORKDIR=$(mktemp -d)
+  cp "$BATS_TEST_DIRNAME/fixtures/check-version/Chart.yaml" "$WORKDIR/Chart.yaml"
+
+  pushd "$WORKDIR" >/dev/null
+  run bash "$OLDPWD/scripts/check-version.sh"
+  popd >/dev/null
+
+  rm -rf "$WORKDIR"
+  [ "$status" -eq 0 ]
+  source /tmp/build-ctx/build.env
+  [ "$NEXT_VERSION" = "0.3.0" ]
+}
+
+@test "tag exists for commit sets ARTIFACT_EXISTS=true" {
+  mock_set_sequence '[{"code": 200, "body": [{"name": "0.3.0", "commit": {"sha": "abc123"}}]}]'
+  mock_start
+
+  export VERSION_FILE="$BATS_TEST_DIRNAME/fixtures/check-version/VERSION"
+  run bash scripts/check-version.sh
+
+  [ "$status" -eq 0 ]
+  source /tmp/build-ctx/build.env
+  [ "$ARTIFACT_EXISTS" = "true" ]
+  [ "$NEXT_VERSION" = "0.3.0" ]
+}
+
+@test "tag with prefix filters correctly" {
+  mock_set_sequence '[{"code": 200, "body": [{"name": "git-pages/0.3.0", "commit": {"sha": "abc123"}}, {"name": "docker/0.3.0", "commit": {"sha": "abc123"}}]}]'
+  mock_start
+
+  export GIT_TAG_PREFIX="git-pages/"
+  export VERSION_FILE="$BATS_TEST_DIRNAME/fixtures/check-version/VERSION"
+  run bash scripts/check-version.sh
+
+  [ "$status" -eq 0 ]
+  source /tmp/build-ctx/build.env
+  [ "$ARTIFACT_EXISTS" = "true" ]
+  [ "$NEXT_VERSION" = "git-pages/0.3.0" ]
+}
+
+@test "no tag, new version calculated" {
+  mock_set_sequence '[{"code": 200, "body": []}]'
+  mock_start
+
+  export VERSION_FILE="$BATS_TEST_DIRNAME/fixtures/check-version/VERSION"
+  run bash scripts/check-version.sh
+
+  [ "$status" -eq 0 ]
+  source /tmp/build-ctx/build.env
+  [ "$ARTIFACT_EXISTS" = "false" ]
+  [ "$NEXT_VERSION" = "0.3.0" ]
+}
+
+@test "highest patch calculated correctly" {
+  mock_set_sequence '[{"code": 200, "body": [{"name": "0.3.0", "commit": {"sha": "def456"}}, {"name": "0.3.1", "commit": {"sha": "def456"}}]}]'
+  mock_start
+
+  export VERSION_FILE="$BATS_TEST_DIRNAME/fixtures/check-version/VERSION"
+  run bash scripts/check-version.sh
+
+  [ "$status" -eq 0 ]
+  source /tmp/build-ctx/build.env
+  [ "$ARTIFACT_EXISTS" = "false" ]
+  [ "$NEXT_VERSION" = "0.3.2" ]
+}
+
+@test "no version source exits with error" {
+  mock_set_sequence '[{"code": 200, "body": []}]'
+  mock_start
+
+  WORKDIR=$(mktemp -d)
+  pushd "$WORKDIR" >/dev/null
+  run bash "$OLDPWD/scripts/check-version.sh"
+  popd >/dev/null
+
+  rm -rf "$WORKDIR"
+  [ "$status" -eq 1 ]
+  [[ "$output" == *"ERROR"* ]]
+}
diff --git a/tests/fixtures/check-version/Chart.yaml b/tests/fixtures/check-version/Chart.yaml
new file mode 100644
index 0000000..0f63843
--- /dev/null
+++ b/tests/fixtures/check-version/Chart.yaml
@@ -0,0 +1,6 @@
+apiVersion: v2
+name: test-chart
+description: Test chart for version extraction
+type: application
+version: 0.3.0
+appVersion: "1.0.0"
diff --git a/tests/fixtures/check-version/VERSION b/tests/fixtures/check-version/VERSION
new file mode 100644
index 0000000..0d91a54
--- /dev/null
+++ b/tests/fixtures/check-version/VERSION
@@ -0,0 +1 @@
+0.3.0
diff --git a/tests/fixtures/check-version/package.json b/tests/fixtures/check-version/package.json
new file mode 100644
index 0000000..edf216a
--- /dev/null
+++ b/tests/fixtures/check-version/package.json
@@ -0,0 +1 @@
+{"version": "0.3.0"}
diff --git a/tests/fixtures/check-version/pom.xml b/tests/fixtures/check-version/pom.xml
new file mode 100644
index 0000000..2f69c2a
--- /dev/null
+++ b/tests/fixtures/check-version/pom.xml
@@ -0,0 +1 @@
+<project><version>0.3.0</version></project>
diff --git a/tests/fixtures/check-version/subdir/Chart.yaml b/tests/fixtures/check-version/subdir/Chart.yaml
new file mode 100644
index 0000000..744cae7
--- /dev/null
+++ b/tests/fixtures/check-version/subdir/Chart.yaml
@@ -0,0 +1,6 @@
+apiVersion: v2
+name: subdir-chart
+description: Chart in subdirectory for monorepo testing
+type: application
+version: 0.4.0
+appVersion: "1.0.0"